spore-gateway/internal/server/server.go

package server

import (
	"context"
	"encoding/json"
	"fmt"
	"io"
	"net/http"
	"strings"
	"sync"
	"time"

	"spore-gateway/internal/discovery"
	"spore-gateway/internal/websocket"
	"spore-gateway/pkg/client"
	"spore-gateway/pkg/registry"

	"github.com/gorilla/mux"
	log "github.com/sirupsen/logrus"
)

// HTTPServer represents the HTTP server
type HTTPServer struct {
	port            string
	router          *mux.Router
	nodeDiscovery   *discovery.NodeDiscovery
	sporeClients    map[string]*client.SporeClient
	webSocketServer *websocket.WebSocketServer
	registryClient  *registry.RegistryClient
	server          *http.Server
}

// NewHTTPServer creates a new HTTP server instance
func NewHTTPServer(port string, nodeDiscovery *discovery.NodeDiscovery) *HTTPServer {
	// Initialize WebSocket server
	wsServer := websocket.NewWebSocketServer(nodeDiscovery)

	// Initialize registry client
	registryClient := registry.NewRegistryClient("http://localhost:3002")

	hs := &HTTPServer{
		port:            port,
		router:          mux.NewRouter(),
		nodeDiscovery:   nodeDiscovery,
		sporeClients:    make(map[string]*client.SporeClient),
		webSocketServer: wsServer,
		registryClient:  registryClient,
	}

	hs.setupRoutes()
	hs.setupMiddleware()

	hs.server = &http.Server{
		Addr:         ":" + port,
		Handler:      hs.router,
		ReadTimeout:  30 * time.Second,
		WriteTimeout: 30 * time.Second,
		IdleTimeout:  60 * time.Second,
	}

	return hs
}

// setupMiddleware configures middleware for the server
func (hs *HTTPServer) setupMiddleware() {
	// CORS middleware
	hs.router.Use(hs.corsMiddleware)

	// JSON middleware
	hs.router.Use(hs.jsonMiddleware)

	// Logging middleware
	hs.router.Use(hs.loggingMiddleware)
}

// corsMiddleware handles CORS headers
func (hs *HTTPServer) corsMiddleware(next http.Handler) http.Handler {
	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		w.Header().Set("Access-Control-Allow-Origin", "*")
		w.Header().Set("Access-Control-Allow-Methods", "GET, POST, PUT, DELETE, OPTIONS")
		w.Header().Set("Access-Control-Allow-Headers", "Content-Type, Authorization, Accept")
		w.Header().Set("Access-Control-Expose-Headers", "Content-Type, Content-Length")

		if r.Method == "OPTIONS" {
			w.WriteHeader(http.StatusOK)
			return
		}

		next.ServeHTTP(w, r)
	})
}

// jsonMiddleware sets JSON content type
func (hs *HTTPServer) jsonMiddleware(next http.Handler) http.Handler {
	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		w.Header().Set("Content-Type", "application/json")
		next.ServeHTTP(w, r)
	})
}

// loggingMiddleware logs HTTP requests
func (hs *HTTPServer) loggingMiddleware(next http.Handler) http.Handler {
	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		start := time.Now()
		next.ServeHTTP(w, r)
		log.WithFields(log.Fields{
			"method":      r.Method,
			"path":        r.URL.Path,
			"remote_addr": r.RemoteAddr,
			"user_agent":  r.UserAgent(),
			"duration":    time.Since(start),
		}).Debug("HTTP request")
	})
}

// setupRoutes configures all the API routes
func (hs *HTTPServer) setupRoutes() {
	// API routes
	api := hs.router.PathPrefix("/api").Subrouter()

	// Apply CORS middleware to API subrouter as well
	api.Use(hs.corsMiddleware)

	// Discovery endpoints
	api.HandleFunc("/discovery/nodes", hs.getDiscoveryNodes).Methods("GET")
	api.HandleFunc("/discovery/refresh", hs.refreshDiscovery).Methods("POST", "OPTIONS")
	api.HandleFunc("/discovery/random-primary", hs.selectRandomPrimary).Methods("POST", "OPTIONS")
	api.HandleFunc("/discovery/primary/{ip}", hs.setPrimaryNode).Methods("POST", "OPTIONS")

	// Cluster endpoints
	api.HandleFunc("/cluster/members", hs.getClusterMembers).Methods("GET")
	api.HandleFunc("/cluster/refresh", hs.refreshCluster).Methods("POST", "OPTIONS")
	api.HandleFunc("/cluster/node/versions", hs.getClusterNodeVersions).Methods("GET")
	api.HandleFunc("/rollout", hs.startRollout).Methods("POST", "OPTIONS")

	// Task endpoints
	api.HandleFunc("/tasks/status", hs.getTaskStatus).Methods("GET")

	// Node endpoints
	api.HandleFunc("/node/status", hs.getNodeStatus).Methods("GET")
	api.HandleFunc("/node/status/{ip}", hs.getNodeStatusByIP).Methods("GET")
	api.HandleFunc("/node/endpoints", hs.getNodeEndpoints).Methods("GET")
	api.HandleFunc("/node/update", hs.updateNodeFirmware).Methods("POST", "OPTIONS")

	// Proxy endpoints
	api.HandleFunc("/proxy-call", hs.proxyCall).Methods("POST", "OPTIONS")

	// Registry proxy endpoints
	api.HandleFunc("/registry/health", hs.getRegistryHealth).Methods("GET")
	api.HandleFunc("/registry/firmware", hs.listRegistryFirmware).Methods("GET")
	api.HandleFunc("/registry/firmware", hs.uploadRegistryFirmware).Methods("POST", "OPTIONS")
	api.HandleFunc("/registry/firmware/{name}/{version}", hs.downloadRegistryFirmware).Methods("GET")
	api.HandleFunc("/registry/firmware/{name}/{version}", hs.updateRegistryFirmware).Methods("PUT", "OPTIONS")
	api.HandleFunc("/registry/firmware/{name}/{version}", hs.deleteRegistryFirmware).Methods("DELETE", "OPTIONS")

	// Test endpoints
	api.HandleFunc("/test/websocket", hs.testWebSocket).Methods("POST", "OPTIONS")

	// Health check
	api.HandleFunc("/health", hs.healthCheck).Methods("GET")

	// WebSocket endpoint - apply CORS middleware
	hs.router.HandleFunc("/ws", hs.corsMiddleware(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		if err := hs.webSocketServer.HandleWebSocket(w, r); err != nil {
			log.WithError(err).Error("WebSocket connection failed")
			http.Error(w, "WebSocket upgrade failed", http.StatusBadRequest)
		}
	})).ServeHTTP)
}

// Start starts the HTTP server
func (hs *HTTPServer) Start() error {
	log.WithField("port", hs.port).Info("Starting HTTP server")
	return hs.server.ListenAndServe()
}

// Shutdown gracefully shuts down the HTTP server
func (hs *HTTPServer) Shutdown(ctx context.Context) error {
	log.Info("Shutting down HTTP server")

	// Shutdown WebSocket server
	if err := hs.webSocketServer.Shutdown(ctx); err != nil {
		log.WithError(err).Error("WebSocket server shutdown error")
	}

	return hs.server.Shutdown(ctx)
}

// Helper function to get or create SPORE client for a node
func (hs *HTTPServer) getSporeClient(nodeIP string) *client.SporeClient {
	if client, exists := hs.sporeClients[nodeIP]; exists {
		return client
	}

	client := client.NewSporeClient(fmt.Sprintf("http://%s", nodeIP))
	hs.sporeClients[nodeIP] = client
	return client
}

// Helper function to perform operation with failover
func (hs *HTTPServer) performWithFailover(operation func(*client.SporeClient) (interface{}, error)) (interface{}, error) {
	primaryNode := hs.nodeDiscovery.GetPrimaryNode()
	nodes := hs.nodeDiscovery.GetNodes()

	if len(nodes) == 0 {
		return nil, fmt.Errorf("no SPORE nodes discovered")
	}

	// Build candidate list: primary first, then others by most recently seen
	var candidateIPs []string
	if primaryNode != "" {
		if _, exists := nodes[primaryNode]; exists {
			candidateIPs = append(candidateIPs, primaryNode)
		}
	}

	for _, node := range nodes {
		if node.IP != primaryNode {
			candidateIPs = append(candidateIPs, node.IP)
		}
	}

	var lastError error
	for _, ip := range candidateIPs {
		client := hs.getSporeClient(ip)
		result, err := operation(client)
		if err == nil {
			// Success - if this wasn't the primary, switch to it
			if ip != primaryNode && primaryNode != "" {
				hs.nodeDiscovery.SetPrimaryNode(ip)
				log.WithField("ip", ip).Info("Failover: switched primary node")
			}
			return result, nil
		}

		log.WithFields(log.Fields{
			"ip":  ip,
			"err": err,
		}).Warn("Primary attempt failed")
		lastError = err
	}

	return nil, lastError
}

// API endpoint handlers

// GET /api/discovery/nodes
func (hs *HTTPServer) getDiscoveryNodes(w http.ResponseWriter, r *http.Request) {
	nodes := hs.nodeDiscovery.GetNodes()
	primaryNode := hs.nodeDiscovery.GetPrimaryNode()
	clusterStatus := hs.nodeDiscovery.GetClusterStatus()

	// Create response with enhanced node info including IsPrimary
	type NodeResponse struct {
		*discovery.NodeInfo
		IsPrimary bool `json:"isPrimary"`
	}

	response := struct {
		PrimaryNode       string                  `json:"primaryNode"`
		TotalNodes        int                     `json:"totalNodes"`
		Nodes             []NodeResponse          `json:"nodes"`
		ClientInitialized bool                    `json:"clientInitialized"`
		ClientBaseURL     string                  `json:"clientBaseUrl"`
		ClusterStatus     discovery.ClusterStatus `json:"clusterStatus"`
	}{
		PrimaryNode:       primaryNode,
		TotalNodes:        len(nodes),
		Nodes:             make([]NodeResponse, 0, len(nodes)),
		ClientInitialized: primaryNode != "",
		ClientBaseURL:     "",
		ClusterStatus:     clusterStatus,
	}

	for _, node := range nodes {
		nodeResponse := NodeResponse{
			NodeInfo:  node,
			IsPrimary: node.IP == primaryNode,
		}
		response.Nodes = append(response.Nodes, nodeResponse)
	}

	json.NewEncoder(w).Encode(response)
}

// POST /api/discovery/refresh
func (hs *HTTPServer) refreshDiscovery(w http.ResponseWriter, r *http.Request) {
	// Mark stale nodes and update primary if needed
	// The node discovery system handles this automatically via its cleanup routine

	response := struct {
		Success           bool   `json:"success"`
		Message           string `json:"message"`
		PrimaryNode       string `json:"primaryNode"`
		TotalNodes        int    `json:"totalNodes"`
		ClientInitialized bool   `json:"clientInitialized"`
	}{
		Success:           true,
		Message:           "Cluster refresh completed",
		PrimaryNode:       hs.nodeDiscovery.GetPrimaryNode(),
		TotalNodes:        len(hs.nodeDiscovery.GetNodes()),
		ClientInitialized: hs.nodeDiscovery.GetPrimaryNode() != "",
	}

	json.NewEncoder(w).Encode(response)
}

// POST /api/discovery/random-primary
func (hs *HTTPServer) selectRandomPrimary(w http.ResponseWriter, r *http.Request) {
	nodes := hs.nodeDiscovery.GetNodes()
	if len(nodes) == 0 {
		http.Error(w, `{"error": "No nodes available", "message": "No SPORE nodes have been discovered yet"}`, http.StatusNotFound)
		return
	}

	newPrimary := hs.nodeDiscovery.SelectRandomPrimaryNode()
	if newPrimary == "" {
		http.Error(w, `{"error": "Selection failed", "message": "Failed to select a random primary node"}`, http.StatusInternalServerError)
		return
	}

	response := struct {
		Success           bool   `json:"success"`
		Message           string `json:"message"`
		PrimaryNode       string `json:"primaryNode"`
		TotalNodes        int    `json:"totalNodes"`
		ClientInitialized bool   `json:"clientInitialized"`
		Timestamp         string `json:"timestamp"`
	}{
		Success:           true,
		Message:           fmt.Sprintf("Randomly selected new primary node: %s", newPrimary),
		PrimaryNode:       newPrimary,
		TotalNodes:        len(nodes),
		ClientInitialized: true,
		Timestamp:         time.Now().Format(time.RFC3339),
	}

	json.NewEncoder(w).Encode(response)
}

// POST /api/discovery/primary/{ip}
func (hs *HTTPServer) setPrimaryNode(w http.ResponseWriter, r *http.Request) {
	vars := mux.Vars(r)
	requestedIP := vars["ip"]

	if err := hs.nodeDiscovery.SetPrimaryNode(requestedIP); err != nil {
		http.Error(w, fmt.Sprintf(`{"error": "Node not found", "message": "Node with IP %s has not been discovered"}`, requestedIP), http.StatusNotFound)
		return
	}

	response := struct {
		Success           bool   `json:"success"`
		Message           string `json:"message"`
		PrimaryNode       string `json:"primaryNode"`
		ClientInitialized bool   `json:"clientInitialized"`
	}{
		Success:           true,
		Message:           fmt.Sprintf("Primary node set to %s", requestedIP),
		PrimaryNode:       requestedIP,
		ClientInitialized: true,
	}

	json.NewEncoder(w).Encode(response)
}

// GET /api/cluster/members
func (hs *HTTPServer) getClusterMembers(w http.ResponseWriter, r *http.Request) {
	log.Debug("Fetching cluster members via API")

	result, err := hs.performWithFailover(func(client *client.SporeClient) (interface{}, error) {
		return client.GetClusterStatus()
	})

	if err != nil {
		log.WithError(err).Debug("Failed to fetch cluster members")
		http.Error(w, fmt.Sprintf(`{"error": "Failed to fetch cluster members", "message": "%s"}`, err.Error()), http.StatusBadGateway)
		return
	}

	log.Debug("Successfully fetched cluster members via API")
	json.NewEncoder(w).Encode(result)
}

// POST /api/cluster/refresh
func (hs *HTTPServer) refreshCluster(w http.ResponseWriter, r *http.Request) {
	var requestBody struct {
		Reason string `json:"reason"`
	}

	if err := json.NewDecoder(r.Body).Decode(&requestBody); err != nil && err.Error() != "EOF" {
		http.Error(w, `{"error": "Invalid JSON", "message": "Failed to parse request body"}`, http.StatusBadRequest)
		return
	}

	reason := requestBody.Reason
	if reason == "" {
		reason = "manual_refresh"
	}

	log.WithField("reason", reason).Info("Manual cluster refresh triggered")

	response := struct {
		Success   bool   `json:"success"`
		Message   string `json:"message"`
		Reason    string `json:"reason"`
		WSclients int    `json:"wsClients"`
	}{
		Success:   true,
		Message:   "Cluster refresh triggered",
		Reason:    reason,
		WSclients: hs.webSocketServer.GetClientCount(),
	}

	json.NewEncoder(w).Encode(response)
}

// GET /api/tasks/status
func (hs *HTTPServer) getTaskStatus(w http.ResponseWriter, r *http.Request) {
	ip := r.URL.Query().Get("ip")

	if ip != "" {
		log.WithField("node_ip", ip).Debug("Fetching task status from specific node")
		client := hs.getSporeClient(ip)
		result, err := client.GetTaskStatus()
		if err != nil {
			log.WithFields(log.Fields{
				"node_ip": ip,
				"error":   err.Error(),
			}).Debug("Failed to fetch task status from specific node")
			http.Error(w, fmt.Sprintf(`{"error": "Failed to fetch task status from node", "message": "%s"}`, err.Error()), http.StatusInternalServerError)
			return
		}
		log.WithField("node_ip", ip).Debug("Successfully fetched task status from specific node")
		json.NewEncoder(w).Encode(result)
		return
	}

	log.Debug("Fetching task status via failover")
	result, err := hs.performWithFailover(func(client *client.SporeClient) (interface{}, error) {
		return client.GetTaskStatus()
	})

	if err != nil {
		log.WithError(err).Debug("Failed to fetch task status via failover")
		http.Error(w, fmt.Sprintf(`{"error": "Failed to fetch task status", "message": "%s"}`, err.Error()), http.StatusBadGateway)
		return
	}

	log.Debug("Successfully fetched task status via failover")
	json.NewEncoder(w).Encode(result)
}

// GET /api/node/status
func (hs *HTTPServer) getNodeStatus(w http.ResponseWriter, r *http.Request) {
	log.Debug("Fetching node system status via failover")

	result, err := hs.performWithFailover(func(client *client.SporeClient) (interface{}, error) {
		return client.GetSystemStatus()
	})

	if err != nil {
		log.WithError(err).Debug("Failed to fetch system status via failover")
		http.Error(w, fmt.Sprintf(`{"error": "Failed to fetch system status", "message": "%s"}`, err.Error()), http.StatusBadGateway)
		return
	}

	log.Debug("Successfully fetched system status via failover")
	json.NewEncoder(w).Encode(result)
}

// GET /api/node/status/{ip}
func (hs *HTTPServer) getNodeStatusByIP(w http.ResponseWriter, r *http.Request) {
	vars := mux.Vars(r)
	nodeIP := vars["ip"]

	log.WithField("node_ip", nodeIP).Debug("Fetching system status from specific node")

	client := hs.getSporeClient(nodeIP)
	result, err := client.GetSystemStatus()
	if err != nil {
		log.WithFields(log.Fields{
			"node_ip": nodeIP,
			"error":   err.Error(),
		}).Debug("Failed to fetch status from specific node")
		http.Error(w, fmt.Sprintf(`{"error": "Failed to fetch status from node %s", "message": "%s"}`, nodeIP, err.Error()), http.StatusInternalServerError)
		return
	}

	log.WithField("node_ip", nodeIP).Debug("Successfully fetched status from specific node")
	json.NewEncoder(w).Encode(result)
}

// GET /api/node/endpoints
func (hs *HTTPServer) getNodeEndpoints(w http.ResponseWriter, r *http.Request) {
	ip := r.URL.Query().Get("ip")

	if ip != "" {
		log.WithField("node_ip", ip).Debug("Fetching endpoints from specific node")
		client := hs.getSporeClient(ip)
		result, err := client.GetCapabilities()
		if err != nil {
			log.WithFields(log.Fields{
				"node_ip": ip,
				"error":   err.Error(),
			}).Debug("Failed to fetch endpoints from specific node")
			http.Error(w, fmt.Sprintf(`{"error": "Failed to fetch endpoints from node", "message": "%s"}`, err.Error()), http.StatusInternalServerError)
			return
		}
		log.WithField("node_ip", ip).Debug("Successfully fetched endpoints from specific node")
		json.NewEncoder(w).Encode(result)
		return
	}

	log.Debug("Fetching capabilities via failover")
	result, err := hs.performWithFailover(func(client *client.SporeClient) (interface{}, error) {
		return client.GetCapabilities()
	})

	if err != nil {
		log.WithError(err).Debug("Failed to fetch capabilities via failover")
		http.Error(w, fmt.Sprintf(`{"error": "Failed to fetch capabilities", "message": "%s"}`, err.Error()), http.StatusBadGateway)
		return
	}

	log.Debug("Successfully fetched capabilities via failover")
	json.NewEncoder(w).Encode(result)
}

// POST /api/node/update
func (hs *HTTPServer) updateNodeFirmware(w http.ResponseWriter, r *http.Request) {
	nodeIP := r.URL.Query().Get("ip")
	if nodeIP == "" {
		nodeIP = r.Header.Get("X-Node-IP")
	}

	if nodeIP == "" {
		w.Header().Set("Content-Type", "application/json")
		w.WriteHeader(http.StatusBadRequest)
		w.Write([]byte(`{"error": "Node IP address is required", "message": "Please provide the target node IP address"}`))
		return
	}

	// Parse multipart form
	err := r.ParseMultipartForm(50 << 20) // 50MB limit
	if err != nil {
		log.WithError(err).Error("Error parsing multipart form")
		w.Header().Set("Content-Type", "application/json")
		w.WriteHeader(http.StatusBadRequest)
		w.Write([]byte(`{"error": "Failed to parse form", "message": "Error parsing multipart form data"}`))
		return
	}

	file, fileHeader, err := r.FormFile("file")
	if err != nil {
		log.WithError(err).Error("No file found in form")
		w.Header().Set("Content-Type", "application/json")
		w.WriteHeader(http.StatusBadRequest)
		w.Write([]byte(`{"error": "No file data received", "message": "Please select a firmware file to upload"}`))
		return
	}
	defer file.Close()

	// Get the original filename
	filename := fileHeader.Filename
	if filename == "" {
		filename = "firmware.bin"
	}

	// Read file data efficiently
	fileData, err := io.ReadAll(file)
	if err != nil {
		log.WithError(err).Error("Error reading file data")
		w.Header().Set("Content-Type", "application/json")
		w.WriteHeader(http.StatusInternalServerError)
		w.Write([]byte(`{"error": "Failed to read file", "message": "Error reading uploaded file data"}`))
		return
	}

	log.WithFields(log.Fields{
		"node_ip":   nodeIP,
		"file_size": len(fileData),
	}).Info("Firmware upload received")

	// Broadcast firmware upload status to WebSocket clients
	hs.webSocketServer.BroadcastFirmwareUploadStatus(nodeIP, "uploading", filename, len(fileData))

	// Send immediate acknowledgment to client
	response := struct {
		Success  bool   `json:"success"`
		Message  string `json:"message"`
		NodeIP   string `json:"nodeIp"`
		FileSize int    `json:"fileSize"`
		Filename string `json:"filename"`
		Status   string `json:"status"`
	}{
		Success:  true,
		Message:  "Firmware upload received, processing...",
		NodeIP:   nodeIP,
		FileSize: len(fileData),
		Filename: filename,
		Status:   "processing",
	}

	log.WithFields(log.Fields{
		"node_ip":   nodeIP,
		"file_size": len(fileData),
		"filename":  filename,
	}).Info("Sending immediate acknowledgment to client")

	// Set response headers to ensure immediate delivery
	w.Header().Set("Content-Type", "application/json")
	w.Header().Set("Cache-Control", "no-cache")

	if err := json.NewEncoder(w).Encode(response); err != nil {
		log.WithError(err).Error("Failed to encode firmware upload acknowledgment")
		return
	}

	log.WithFields(log.Fields{
		"node_ip":  nodeIP,
		"status":   "acknowledgment_sent",
		"response": response,
	}).Debug("Firmware upload acknowledgment sent to client")

	// Flush the response to ensure it's sent immediately
	if f, ok := w.(http.Flusher); ok {
		f.Flush()
		log.WithField("node_ip", nodeIP).Debug("Acknowledgment flushed to client")
	}

	// Now process the firmware upload in the background
	go func() {
		client := hs.getSporeClient(nodeIP)
		result, err := client.UpdateFirmware(fileData, filename)
		if err != nil {
			log.WithFields(log.Fields{
				"node_ip": nodeIP,
				"error":   err.Error(),
			}).Error("Error uploading firmware to device")

			// Broadcast failure status to WebSocket clients
			hs.webSocketServer.BroadcastFirmwareUploadStatus(nodeIP, "failed", filename, len(fileData))
			return
		}

		// Check if the device reported a failure
		if result.Status == "FAIL" {
			log.WithFields(log.Fields{
				"node_ip": nodeIP,
				"message": result.Message,
			}).Error("Device reported firmware update failure")

			// Broadcast failure status to WebSocket clients
			hs.webSocketServer.BroadcastFirmwareUploadStatus(nodeIP, "failed", filename, len(fileData))
			return
		}

		log.WithFields(log.Fields{
			"node_ip":   nodeIP,
			"file_size": len(fileData),
			"filename":  filename,
			"result":    result.Status,
		}).Info("Firmware upload completed successfully")

		// Broadcast success status to WebSocket clients
		hs.webSocketServer.BroadcastFirmwareUploadStatus(nodeIP, "completed", filename, len(fileData))
	}()
}

// POST /api/proxy-call
func (hs *HTTPServer) proxyCall(w http.ResponseWriter, r *http.Request) {
	var requestBody struct {
		IP     string                   `json:"ip"`
		Method string                   `json:"method"`
		URI    string                   `json:"uri"`
		Params []map[string]interface{} `json:"params"`
	}

	if err := json.NewDecoder(r.Body).Decode(&requestBody); err != nil {
		http.Error(w, `{"error": "Invalid JSON", "message": "Failed to parse request body"}`, http.StatusBadRequest)
		return
	}

	if requestBody.IP == "" || requestBody.Method == "" || requestBody.URI == "" {
		http.Error(w, `{"error": "Missing required fields", "message": "Required: ip, method, uri"}`, http.StatusBadRequest)
		return
	}

	// Convert params to map for client
	params := make(map[string]interface{})
	for _, param := range requestBody.Params {
		if name, ok := param["name"].(string); ok {
			// Create parameter object preserving UI-provided metadata
			paramObj := map[string]interface{}{
				"location": "body",   // default location
				"type":     "string", // default type
			}

			// Preserve the UI's location and type information
			if location, ok := param["location"].(string); ok && location != "" {
				paramObj["location"] = location
			}
			if paramType, ok := param["type"].(string); ok && paramType != "" {
				paramObj["type"] = paramType
			}

			// Extract the actual value from the parameter object
			if value, ok := param["value"]; ok {
				paramObj["value"] = value
			} else {
				paramObj["value"] = param
			}

			// Keep the value as-is, don't try to auto-detect JSON
			// The UI will specify the correct type, and the client will handle it appropriately

			params[name] = paramObj
		}
	}

	client := hs.getSporeClient(requestBody.IP)
	resp, err := client.ProxyCall(requestBody.Method, requestBody.URI, params)
	if err != nil {
		log.WithError(err).Error("Error in proxy call")
		http.Error(w, fmt.Sprintf(`{"error": "Proxy call failed", "message": "%s"}`, err.Error()), http.StatusInternalServerError)
		return
	}
	defer resp.Body.Close()

	// Read response
	body, err := io.ReadAll(resp.Body)
	if err != nil {
		log.WithError(err).Error("Error reading proxy response")
		http.Error(w, `{"error": "Failed to read response", "message": "Error reading upstream response"}`, http.StatusInternalServerError)
		return
	}

	// Set appropriate content type
	contentType := resp.Header.Get("Content-Type")
	if contentType != "" {
		w.Header().Set("Content-Type", contentType)
	}

	// Set CORS headers for proxy responses
	w.Header().Set("Access-Control-Allow-Origin", "*")
	w.Header().Set("Access-Control-Allow-Methods", "GET, POST, PUT, DELETE, OPTIONS")
	w.Header().Set("Access-Control-Allow-Headers", "Content-Type, Authorization")

	// Set status code
	w.WriteHeader(resp.StatusCode)

	// For consistency with frontend expectations, wrap response in data field for JSON responses
	if contentType != "" && strings.Contains(contentType, "application/json") {
		// Try to parse and re-wrap the JSON response
		var jsonResp interface{}
		if err := json.Unmarshal(body, &jsonResp); err == nil {
			wrappedResp := map[string]interface{}{
				"data":   jsonResp,
				"status": resp.StatusCode,
			}
			body, _ = json.Marshal(wrappedResp)
		}
	}

	// Write response body
	w.Write(body)
}

// POST /api/test/websocket
func (hs *HTTPServer) testWebSocket(w http.ResponseWriter, r *http.Request) {
	log.Info("Manual WebSocket test triggered")

	response := struct {
		Success    bool   `json:"success"`
		Message    string `json:"message"`
		WSclients  int    `json:"websocketClients"`
		TotalNodes int    `json:"totalNodes"`
	}{
		Success:    true,
		Message:    "WebSocket test broadcast sent",
		WSclients:  hs.webSocketServer.GetClientCount(),
		TotalNodes: len(hs.nodeDiscovery.GetNodes()),
	}

	json.NewEncoder(w).Encode(response)
}

// GET /api/health
func (hs *HTTPServer) healthCheck(w http.ResponseWriter, r *http.Request) {
	primaryNode := hs.nodeDiscovery.GetPrimaryNode()
	nodes := hs.nodeDiscovery.GetNodes()
	clusterStatus := hs.nodeDiscovery.GetClusterStatus()

	health := struct {
		Status    string                 `json:"status"`
		Timestamp string                 `json:"timestamp"`
		Services  map[string]bool        `json:"services"`
		Cluster   map[string]interface{} `json:"cluster"`
	}{
		Status:    "healthy",
		Timestamp: time.Now().Format(time.RFC3339),
		Services: map[string]bool{
			"http":        true,
			"udp":         clusterStatus.ServerRunning,
			"sporeClient": primaryNode != "",
		},
		Cluster: map[string]interface{}{
			"totalNodes":    clusterStatus.TotalNodes,
			"primaryNode":   clusterStatus.PrimaryNode,
			"udpPort":       clusterStatus.UDPPort,
			"serverRunning": clusterStatus.ServerRunning,
		},
	}

	// Mark as degraded if no nodes discovered
	if len(nodes) == 0 {
		health.Status = "degraded"
	}

	// Mark as degraded if no client initialized
	if primaryNode == "" {
		health.Status = "degraded"
	}

	statusCode := http.StatusOK
	if health.Status != "healthy" {
		statusCode = http.StatusServiceUnavailable
	}

	w.WriteHeader(statusCode)
	json.NewEncoder(w).Encode(health)
}

// RolloutRequest represents a rollout request
type RolloutRequest struct {
	Firmware FirmwareInfo `json:"firmware"`
	Nodes    []NodeInfo   `json:"nodes"`
}

// FirmwareInfo represents firmware information
type FirmwareInfo struct {
	Name    string            `json:"name"`
	Version string            `json:"version"`
	Labels  map[string]string `json:"labels"`
}

// NodeInfo represents node information
type NodeInfo struct {
	IP      string            `json:"ip"`
	Version string            `json:"version"`
	Labels  map[string]string `json:"labels"`
}

// RolloutResponse represents a rollout response
type RolloutResponse struct {
	Success     bool   `json:"success"`
	Message     string `json:"message"`
	RolloutID   string `json:"rolloutId"`
	TotalNodes  int    `json:"totalNodes"`
	FirmwareURL string `json:"firmwareUrl"`
}

// NodeVersionInfo represents node version information
type NodeVersionInfo struct {
	IP      string            `json:"ip"`
	Version string            `json:"version"`
	Labels  map[string]string `json:"labels"`
}

// ClusterNodeVersionsResponse represents the response for cluster node versions
type ClusterNodeVersionsResponse struct {
	Nodes []NodeVersionInfo `json:"nodes"`
}

// GET /api/cluster/node/versions
func (hs *HTTPServer) getClusterNodeVersions(w http.ResponseWriter, r *http.Request) {
	log.Debug("Fetching cluster node versions")

	result, err := hs.performWithFailover(func(client *client.SporeClient) (interface{}, error) {
		return client.GetClusterStatus()
	})

	if err != nil {
		log.WithError(err).Debug("Failed to fetch cluster members for versions")
		http.Error(w, fmt.Sprintf(`{"error": "Failed to fetch cluster members", "message": "%s"}`, err.Error()), http.StatusBadGateway)
		return
	}

	clusterStatus, ok := result.(*client.ClusterStatusResponse)
	if !ok {
		log.Debug("Invalid cluster status response type")
		http.Error(w, `{"error": "Invalid cluster status response"}`, http.StatusInternalServerError)
		return
	}

	// Extract version information from cluster members
	var nodeVersions []NodeVersionInfo
	for _, member := range clusterStatus.Members {
		version := "unknown"
		if v, exists := member.Labels["version"]; exists {
			version = v
		}

		nodeVersions = append(nodeVersions, NodeVersionInfo{
			IP:      member.IP,
			Version: version,
			Labels:  member.Labels,
		})
	}

	log.WithField("node_count", len(nodeVersions)).Debug("Successfully fetched cluster node versions")

	response := ClusterNodeVersionsResponse{
		Nodes: nodeVersions,
	}

	json.NewEncoder(w).Encode(response)
}

// POST /api/rollout
func (hs *HTTPServer) startRollout(w http.ResponseWriter, r *http.Request) {
	var request RolloutRequest
	if err := json.NewDecoder(r.Body).Decode(&request); err != nil {
		http.Error(w, `{"error": "Invalid JSON", "message": "Failed to parse request body"}`, http.StatusBadRequest)
		return
	}

	if len(request.Nodes) == 0 {
		http.Error(w, `{"error": "No nodes", "message": "No nodes provided for rollout"}`, http.StatusBadRequest)
		return
	}

	if request.Firmware.Name == "" || request.Firmware.Version == "" {
		http.Error(w, `{"error": "Missing firmware info", "message": "Firmware name and version are required"}`, http.StatusBadRequest)
		return
	}

	log.WithFields(log.Fields{
		"firmware_name":    request.Firmware.Name,
		"firmware_version": request.Firmware.Version,
		"node_count":       len(request.Nodes),
	}).Info("Starting rollout")

	// Look up firmware in registry by name and version
	firmware, err := hs.registryClient.FindFirmwareByNameAndVersion(request.Firmware.Name, request.Firmware.Version)
	if err != nil {
		log.WithError(err).Error("Failed to find firmware in registry")
		http.Error(w, fmt.Sprintf(`{"error": "Firmware not found", "message": "No firmware found with name %s and version %s: %s"}`, request.Firmware.Name, request.Firmware.Version, err.Error()), http.StatusNotFound)
		return
	}

	firmwareURL := fmt.Sprintf("http://localhost:3002/firmware/%s/%s", firmware.Name, firmware.Version)
	rolloutID := fmt.Sprintf("rollout_%d", time.Now().Unix())

	log.WithFields(log.Fields{
		"rollout_id":       rolloutID,
		"matching_nodes":   len(request.Nodes),
		"firmware_name":    request.Firmware.Name,
		"firmware_version": request.Firmware.Version,
	}).Info("Rollout initiated")

	// Send immediate response
	response := RolloutResponse{
		Success:     true,
		Message:     fmt.Sprintf("Rollout started for %d nodes", len(request.Nodes)),
		RolloutID:   rolloutID,
		TotalNodes:  len(request.Nodes),
		FirmwareURL: firmwareURL,
	}

	json.NewEncoder(w).Encode(response)

	// Start rollout process in background
	go hs.processRollout(rolloutID, request.Nodes, request.Firmware)
}

// nodeMatchesLabels checks if a node's labels match the rollout labels
func (hs *HTTPServer) nodeMatchesLabels(nodeLabels, rolloutLabels map[string]string) bool {
	for key, value := range rolloutLabels {
		if nodeValue, exists := nodeLabels[key]; !exists || nodeValue != value {
			return false
		}
	}
	return true
}

// processRollout handles the actual rollout process in the background
func (hs *HTTPServer) processRollout(rolloutID string, nodes []NodeInfo, firmwareInfo FirmwareInfo) {
	log.WithFields(log.Fields{
		"rollout_id": rolloutID,
		"firmware":   fmt.Sprintf("%s/%s", firmwareInfo.Name, firmwareInfo.Version),
		"node_count": len(nodes),
	}).Debug("Starting background rollout process")

	// Download firmware from registry
	log.WithFields(log.Fields{
		"rollout_id": rolloutID,
		"firmware":   fmt.Sprintf("%s/%s", firmwareInfo.Name, firmwareInfo.Version),
	}).Debug("Downloading firmware from registry for rollout")

	firmwareData, err := hs.registryClient.DownloadFirmware(firmwareInfo.Name, firmwareInfo.Version)
	if err != nil {
		log.WithFields(log.Fields{
			"rollout_id": rolloutID,
			"firmware":   fmt.Sprintf("%s/%s", firmwareInfo.Name, firmwareInfo.Version),
			"error":      err.Error(),
		}).Error("Failed to download firmware for rollout")
		return
	}

	log.WithFields(log.Fields{
		"rollout_id":  rolloutID,
		"firmware":    fmt.Sprintf("%s/%s", firmwareInfo.Name, firmwareInfo.Version),
		"size":        len(firmwareData),
		"total_nodes": len(nodes),
	}).Debug("Successfully downloaded firmware for rollout")

	// Process nodes in parallel using goroutines
	var wg sync.WaitGroup

	for i, node := range nodes {
		wg.Add(1)
		go func(nodeIndex int, node NodeInfo) {
			defer wg.Done()

			log.WithFields(log.Fields{
				"rollout_id": rolloutID,
				"node_ip":    node.IP,
				"progress":   fmt.Sprintf("%d/%d", nodeIndex+1, len(nodes)),
			}).Debug("Processing node in rollout")

			// Update version label on the node before upload
			log.WithFields(log.Fields{
				"rollout_id": rolloutID,
				"node_ip":    node.IP,
			}).Debug("Getting SPORE client for node")

			client := hs.getSporeClient(node.IP)

			// Create updated labels with the new version
			updatedLabels := make(map[string]string)
			for k, v := range node.Labels {
				updatedLabels[k] = v
			}

			// Ensure version label is properly formatted
			versionToSet := firmwareInfo.Version
			// Remove 'v' prefix if present to ensure consistency
			versionToSet = strings.TrimPrefix(versionToSet, "v")
			updatedLabels["version"] = versionToSet

			log.WithFields(log.Fields{
				"rollout_id":                rolloutID,
				"node_ip":                   node.IP,
				"old_version":               node.Labels["version"],
				"new_version":               versionToSet,
				"original_firmware_version": firmwareInfo.Version,
				"all_labels":                updatedLabels,
			}).Info("Updating version label on node")

			// Broadcast label update progress
			hs.webSocketServer.BroadcastRolloutProgress(rolloutID, node.IP, "updating_labels", nodeIndex+1, len(nodes))

			if err := client.UpdateNodeLabels(updatedLabels); err != nil {
				log.WithFields(log.Fields{
					"rollout_id": rolloutID,
					"node_ip":    node.IP,
					"error":      err.Error(),
				}).Error("Failed to update version label on node")

				// Broadcast failure
				hs.webSocketServer.BroadcastRolloutProgress(rolloutID, node.IP, "failed", nodeIndex+1, len(nodes))
				return
			}

			log.WithFields(log.Fields{
				"rollout_id": rolloutID,
				"node_ip":    node.IP,
				"version":    versionToSet,
			}).Info("Successfully updated version label on node")

			// Broadcast upload progress
			hs.webSocketServer.BroadcastRolloutProgress(rolloutID, node.IP, "uploading", nodeIndex+1, len(nodes))

			// Upload firmware to node
			result, err := client.UpdateFirmware(firmwareData, fmt.Sprintf("%s-%s.bin", firmwareInfo.Name, firmwareInfo.Version))

			if err != nil {
				log.WithFields(log.Fields{
					"rollout_id": rolloutID,
					"node_ip":    node.IP,
					"error":      err.Error(),
				}).Error("Failed to upload firmware to node")

				// Broadcast failure
				hs.webSocketServer.BroadcastRolloutProgress(rolloutID, node.IP, "failed", nodeIndex+1, len(nodes))
				return
			}

			// Check if the device reported a failure
			if result.Status == "FAIL" {
				log.WithFields(log.Fields{
					"rollout_id": rolloutID,
					"node_ip":    node.IP,
					"message":    result.Message,
				}).Error("Device reported firmware update failure")

				// Broadcast failure
				hs.webSocketServer.BroadcastRolloutProgress(rolloutID, node.IP, "failed", nodeIndex+1, len(nodes))
				return
			}

			log.WithFields(log.Fields{
				"rollout_id": rolloutID,
				"node_ip":    node.IP,
				"result":     result.Status,
			}).Info("Firmware upload completed successfully")

			// Broadcast completion
			hs.webSocketServer.BroadcastRolloutProgress(rolloutID, node.IP, "completed", nodeIndex+1, len(nodes))
		}(i, node)
	}

	// Wait for all goroutines to complete
	wg.Wait()

	log.WithField("rollout_id", rolloutID).Info("Rollout process completed")
}

// Registry proxy handlers

// GET /api/registry/health
func (hs *HTTPServer) getRegistryHealth(w http.ResponseWriter, r *http.Request) {
	health, err := hs.registryClient.GetHealth()
	if err != nil {
		log.WithError(err).Error("Failed to get registry health")
		http.Error(w, fmt.Sprintf(`{"error": "Registry health check failed", "message": "%s"}`, err.Error()), http.StatusServiceUnavailable)
		return
	}

	w.Header().Set("Content-Type", "application/json")
	json.NewEncoder(w).Encode(health)
}

// GET /api/registry/firmware
func (hs *HTTPServer) listRegistryFirmware(w http.ResponseWriter, r *http.Request) {
	// Get query parameters
	name := r.URL.Query().Get("name")
	version := r.URL.Query().Get("version")

	firmwareList, err := hs.registryClient.ListFirmware()
	if err != nil {
		log.WithError(err).Error("Failed to list registry firmware")
		http.Error(w, fmt.Sprintf(`{"error": "Failed to list firmware", "message": "%s"}`, err.Error()), http.StatusInternalServerError)
		return
	}

	// Filter by name and version if provided
	if name != "" || version != "" {
		filtered := []registry.GroupedFirmware{}
		for _, group := range firmwareList {
			if name != "" && group.Name != name {
				continue
			}

			filteredFirmware := []registry.FirmwareRecord{}
			for _, firmware := range group.Firmware {
				if version != "" && firmware.Version != version {
					continue
				}
				filteredFirmware = append(filteredFirmware, firmware)
			}

			if len(filteredFirmware) > 0 {
				group.Firmware = filteredFirmware
				filtered = append(filtered, group)
			}
		}
		firmwareList = filtered
	}

	w.Header().Set("Content-Type", "application/json")
	json.NewEncoder(w).Encode(firmwareList)
}

// POST /api/registry/firmware
func (hs *HTTPServer) uploadRegistryFirmware(w http.ResponseWriter, r *http.Request) {
	// Parse multipart form
	err := r.ParseMultipartForm(32 << 20) // 32MB max
	if err != nil {
		log.WithError(err).Error("Failed to parse multipart form")
		http.Error(w, `{"error": "Invalid form data", "message": "Failed to parse multipart form"}`, http.StatusBadRequest)
		return
	}

	// Get metadata from form
	metadataJSON := r.FormValue("metadata")
	if metadataJSON == "" {
		http.Error(w, `{"error": "Missing metadata", "message": "Metadata field is required"}`, http.StatusBadRequest)
		return
	}

	var metadata registry.FirmwareMetadata
	if err := json.Unmarshal([]byte(metadataJSON), &metadata); err != nil {
		log.WithError(err).Error("Invalid metadata JSON")
		http.Error(w, `{"error": "Invalid metadata", "message": "Failed to parse metadata JSON"}`, http.StatusBadRequest)
		return
	}

	// Get firmware file
	file, _, err := r.FormFile("firmware")
	if err != nil {
		log.WithError(err).Error("Missing firmware file")
		http.Error(w, `{"error": "Missing firmware file", "message": "Firmware file is required"}`, http.StatusBadRequest)
		return
	}
	defer file.Close()

	// Upload to registry
	result, err := hs.registryClient.UploadFirmware(metadata, file)
	if err != nil {
		log.WithError(err).Error("Failed to upload firmware to registry")
		http.Error(w, fmt.Sprintf(`{"error": "Upload failed", "message": "%s"}`, err.Error()), http.StatusInternalServerError)
		return
	}

	w.Header().Set("Content-Type", "application/json")
	json.NewEncoder(w).Encode(result)
}

// GET /api/registry/firmware/{name}/{version}
func (hs *HTTPServer) downloadRegistryFirmware(w http.ResponseWriter, r *http.Request) {
	vars := mux.Vars(r)
	name := vars["name"]
	version := vars["version"]

	if name == "" || version == "" {
		http.Error(w, `{"error": "Missing parameters", "message": "Name and version are required"}`, http.StatusBadRequest)
		return
	}

	firmwareData, err := hs.registryClient.DownloadFirmware(name, version)
	if err != nil {
		log.WithError(err).Error("Failed to download firmware from registry")
		http.Error(w, fmt.Sprintf(`{"error": "Download failed", "message": "%s"}`, err.Error()), http.StatusNotFound)
		return
	}

	// Set appropriate headers for file download
	w.Header().Set("Content-Type", "application/octet-stream")
	w.Header().Set("Content-Disposition", fmt.Sprintf("attachment; filename=\"%s-%s.bin\"", name, version))
	w.Header().Set("Content-Length", fmt.Sprintf("%d", len(firmwareData)))

	w.Write(firmwareData)
}

// PUT /api/registry/firmware/{name}/{version}
func (hs *HTTPServer) updateRegistryFirmware(w http.ResponseWriter, r *http.Request) {
	vars := mux.Vars(r)
	name := vars["name"]
	version := vars["version"]

	if name == "" || version == "" {
		http.Error(w, `{"error": "Missing parameters", "message": "Name and version are required"}`, http.StatusBadRequest)
		return
	}

	var metadata registry.FirmwareMetadata
	if err := json.NewDecoder(r.Body).Decode(&metadata); err != nil {
		log.WithError(err).Error("Invalid metadata JSON")
		http.Error(w, `{"error": "Invalid metadata", "message": "Failed to parse metadata JSON"}`, http.StatusBadRequest)
		return
	}

	// Update firmware metadata in registry
	result, err := hs.registryClient.UpdateFirmwareMetadata(name, version, metadata)
	if err != nil {
		log.WithError(err).Error("Failed to update firmware metadata in registry")
		http.Error(w, fmt.Sprintf(`{"error": "Update failed", "message": "%s"}`, err.Error()), http.StatusInternalServerError)
		return
	}

	w.Header().Set("Content-Type", "application/json")
	json.NewEncoder(w).Encode(result)
}

func (hs *HTTPServer) deleteRegistryFirmware(w http.ResponseWriter, r *http.Request) {
	vars := mux.Vars(r)
	name := vars["name"]
	version := vars["version"]

	if name == "" || version == "" {
		http.Error(w, `{"error": "Missing parameters", "message": "Name and version are required"}`, http.StatusBadRequest)
		return
	}

	// Delete firmware from registry
	result, err := hs.registryClient.DeleteFirmware(name, version)
	if err != nil {
		log.WithError(err).Error("Failed to delete firmware from registry")
		http.Error(w, fmt.Sprintf(`{"error": "Delete failed", "message": "%s"}`, err.Error()), http.StatusInternalServerError)
		return
	}

	w.Header().Set("Content-Type", "application/json")
	json.NewEncoder(w).Encode(result)
}