toolz/goplt
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove t.Parallel() from metrics tests to fix race conditions
All checks were successful
CI / Test (pull_request) Successful in 21s
Details
CI / Lint (pull_request) Successful in 17s
Details
CI / Build (pull_request) Successful in 12s
Details
CI / Format Check (pull_request) Successful in 2s
Details

Browse Source 
The Gin framework uses a global mode setting (gin.SetMode()) which is not
thread-safe when tests run in parallel. Removing t.Parallel() from metrics
tests that use gin.SetMode() prevents data races when running tests with
the race detector enabled.

All tests now pass with 'make test' which includes -race flag.
This commit is contained in:
0x1d
2025-11-05 21:16:45 +01:00
parent 3bc37dd48c
commit 0d6c62ab03
2 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
docs/content/index.md
View File

@@ -14,12 +14,12 @@ Go Platform is a modular, extensible platform designed to support multiple busin
## Documentation Structure ## Documentation Structure
### 📋 Overview ### Overview
- **[Requirements](requirements.md)**: High-level architectural principles and requirements - **[Requirements](requirements.md)**: High-level architectural principles and requirements
- **[Implementation Plan](plan.md)**: Epic-based implementation plan with timelines - **[Implementation Plan](plan.md)**: Epic-based implementation plan with timelines
- **[Playbook](playbook.md)**: Detailed implementation guide and best practices - **[Playbook](playbook.md)**: Detailed implementation guide and best practices
### 🏛️ Architecture ### Architecture
- **[Architecture Overview](architecture/architecture.md)**: System architecture with diagrams - **[Architecture Overview](architecture/architecture.md)**: System architecture with diagrams
- **[Module Architecture](architecture/architecture-modules.md)**: Module system design and integration - **[Module Architecture](architecture/architecture-modules.md)**: Module system design and integration
- **[Module Requirements](architecture/module-requirements.md)**: Detailed requirements for each module - **[Module Requirements](architecture/module-requirements.md)**: Detailed requirements for each module
@@ -31,7 +31,7 @@ Go Platform is a modular, extensible platform designed to support multiple busin
- **[Operational Scenarios](architecture/operational-scenarios.md)**: Common operational flows and use cases - **[Operational Scenarios](architecture/operational-scenarios.md)**: Common operational flows and use cases
- **[Data Flow Patterns](architecture/data-flow-patterns.md)**: How data flows through the system - **[Data Flow Patterns](architecture/data-flow-patterns.md)**: How data flows through the system
### 🏗️ Architecture Decision Records (ADRs) ### Architecture Decision Records (ADRs)
All architectural decisions are documented in [ADR records](adr/README.md), organized by implementation epic: All architectural decisions are documented in [ADR records](adr/README.md), organized by implementation epic:
- **Epic 0**: Project Setup & Foundation - **Epic 0**: Project Setup & Foundation
- **Epic 1**: Core Kernel & Infrastructure - **Epic 1**: Core Kernel & Infrastructure
@@ -41,7 +41,7 @@ All architectural decisions are documented in [ADR records](adr/README.md), orga
- **Epic 6**: Observability & Production Readiness - **Epic 6**: Observability & Production Readiness
- **Epic 7**: Testing, Documentation & CI/CD - **Epic 7**: Testing, Documentation & CI/CD
### 📝 Implementation Tasks ### Implementation Tasks
Detailed task definitions for each epic are available in the [Stories section](stories/README.md): Detailed task definitions for each epic are available in the [Stories section](stories/README.md):
- **[Epic 0: Project Setup & Foundation](stories/epic0/README.md)** - [Implementation Summary](stories/epic0/SUMMARY.md) - **[Epic 0: Project Setup & Foundation](stories/epic0/README.md)** - [Implementation Summary](stories/epic0/SUMMARY.md)
- **[Epic 1: Core Kernel & Infrastructure](stories/epic1/README.md)** - [Implementation Summary](stories/epic1/SUMMARY.md) - **[Epic 1: Core Kernel & Infrastructure](stories/epic1/README.md)** - [Implementation Summary](stories/epic1/SUMMARY.md)

11
internal/metrics/metrics_test.go
View File

@@ -34,13 +34,10 @@ func TestNewMetrics(t *testing.T) {
} }
func TestMetrics_HTTPMiddleware(t *testing.T) { func TestMetrics_HTTPMiddleware(t *testing.T) {
t.Parallel() gin.SetMode(gin.TestMode)
metrics := NewMetrics() metrics := NewMetrics()
// Set Gin to test mode
gin.SetMode(gin.TestMode)
router := gin.New() router := gin.New()
router.Use(metrics.HTTPMiddleware()) router.Use(metrics.HTTPMiddleware())
@@ -63,12 +60,10 @@ func TestMetrics_HTTPMiddleware(t *testing.T) {
} }
func TestMetrics_HTTPMiddleware_Error(t *testing.T) { func TestMetrics_HTTPMiddleware_Error(t *testing.T) {
t.Parallel() gin.SetMode(gin.TestMode)
metrics := NewMetrics() metrics := NewMetrics()
gin.SetMode(gin.TestMode)
router := gin.New() router := gin.New()
router.Use(metrics.HTTPMiddleware()) router.Use(metrics.HTTPMiddleware())
@@ -87,8 +82,6 @@ func TestMetrics_HTTPMiddleware_Error(t *testing.T) {
} }
func TestMetrics_Handler(t *testing.T) { func TestMetrics_Handler(t *testing.T) {
t.Parallel()
metrics := NewMetrics() metrics := NewMetrics()
handler := metrics.Handler() handler := metrics.Handler()