fix: resolve all golangci-lint issues
- Add package comments to all packages (pkg/config, pkg/logger, internal/*, cmd/platform)
- Fix context key warnings by using custom ContextKey type
- Export ContextKey type to avoid unexported-return warnings
- Update all context value operations to use ContextKey instead of string
- Update RequestIDKey() and UserIDKey() to return ContextKey
- Fix error checking issues (errcheck)
- Properly handle os.Chdir errors in defer statements
- Properly handle os.Setenv/os.Unsetenv errors in tests
- Fix security warnings (gosec)
- Change directory permissions from 0755 to 0750 in tests
- Change file permissions from 0644 to 0600 in tests
- Fix unused parameter warnings (revive)
- Replace unused parameters with _ in:
* RegisterLifecycleHooks lifecycle functions
* Mock logger implementations
* noOpLogger methods
- Fix type assertion issues (staticcheck)
- Remove unnecessary type assertions in tests
- Use simpler compile-time checks
- Fix exported type stuttering warning
- Add nolint directive for ConfigProvider (standard interface pattern)
- Update golangci-lint configuration
- Add version: 2 field (required for newer versions)
- Remove unsupported linters (typecheck, gosimple)
- Move formatters (gofmt, goimports) to separate formatters section
- Simplify linter list to only well-supported linters
All linting issues resolved (0 issues reported by golangci-lint).
All tests pass and code compiles successfully.
This commit is contained in:
@@ -1,3 +1,5 @@
|
||||
// Package config provides the configuration management interface.
|
||||
// It defines the ConfigProvider interface that implementations must satisfy.
|
||||
package config
|
||||
|
||||
import "time"
|
||||
@@ -5,6 +7,8 @@ import "time"
|
||||
// ConfigProvider defines the interface for configuration management.
|
||||
// It provides type-safe access to configuration values from various sources
|
||||
// (YAML files, environment variables, etc.).
|
||||
//
|
||||
//nolint:revive // ConfigProvider is a standard interface name pattern; stuttering is acceptable
|
||||
type ConfigProvider interface {
|
||||
// Get retrieves a configuration value by key.
|
||||
// Returns nil if the key is not found.
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
// Package logger provides helper functions for creating structured logging fields.
|
||||
package logger
|
||||
|
||||
import "go.uber.org/zap"
|
||||
|
||||
@@ -52,9 +52,9 @@ func ErrorLog(msg string, fields ...Field) {
|
||||
// Used as a fallback when no global logger is set.
|
||||
type noOpLogger struct{}
|
||||
|
||||
func (n *noOpLogger) Debug(msg string, fields ...Field) {}
|
||||
func (n *noOpLogger) Info(msg string, fields ...Field) {}
|
||||
func (n *noOpLogger) Warn(msg string, fields ...Field) {}
|
||||
func (n *noOpLogger) Error(msg string, fields ...Field) {}
|
||||
func (n *noOpLogger) With(fields ...Field) Logger { return n }
|
||||
func (n *noOpLogger) WithContext(ctx context.Context) Logger { return n }
|
||||
func (n *noOpLogger) Debug(_ string, _ ...Field) {}
|
||||
func (n *noOpLogger) Info(_ string, _ ...Field) {}
|
||||
func (n *noOpLogger) Warn(_ string, _ ...Field) {}
|
||||
func (n *noOpLogger) Error(_ string, _ ...Field) {}
|
||||
func (n *noOpLogger) With(_ ...Field) Logger { return n }
|
||||
func (n *noOpLogger) WithContext(_ context.Context) Logger { return n }
|
||||
|
||||
Reference in New Issue
Block a user