fix(lint): fix all linting errors
Some checks failed
CI / Test (pull_request) Successful in 53s
CI / Lint (pull_request) Failing after 26s
CI / Build (pull_request) Successful in 39s
CI / Format Check (pull_request) Failing after 2s

- Check BindEnv return values in config.go
- Add bounds checks for int->int32/uint32 conversions to prevent overflow
- Remove unused test helper functions
This commit is contained in:
2025-11-07 09:34:22 +01:00
parent 131e44f3d4
commit e673fcae6f
7 changed files with 44 additions and 39 deletions

View File

@@ -5,6 +5,7 @@ package main
import (
"context"
"fmt"
"math"
"net"
"time"
@@ -275,9 +276,13 @@ func (s *auditServerImpl) Query(ctx context.Context, req *auditv1.QueryRequest)
})
}
total := len(protoEntries)
if total > math.MaxInt32 {
total = math.MaxInt32
}
return &auditv1.QueryResponse{
Entries: protoEntries,
Total: int32(len(protoEntries)),
Total: int32(total),
}, nil
}

View File

@@ -8,6 +8,7 @@ import (
"crypto/subtle"
"encoding/base64"
"fmt"
"math"
"net"
"strings"
"time"
@@ -72,7 +73,11 @@ func verifyPassword(password, hash string) (bool, error) {
if err != nil {
return false, err
}
actualHash := argon2.IDKey([]byte(password), salt, 3, 64*1024, 4, uint32(len(expectedHash)))
hashLen := len(expectedHash)
if hashLen < 0 || hashLen > math.MaxUint32 {
return false, fmt.Errorf("invalid hash length: %d", hashLen)
}
actualHash := argon2.IDKey([]byte(password), salt, 3, 64*1024, 4, uint32(hashLen))
return subtle.ConstantTimeCompare(expectedHash, actualHash) == 1, nil
}