feature/epic0-foundation #1
Reference in New Issue
Block a user
No description provided.
Delete Branch "feature/epic0-foundation"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
- Remove t.Parallel() from tests that use gin.SetMode() - gin.SetMode() modifies global state and is not thread-safe - Tests affected: * TestRequestIDMiddleware_GenerateNewID * TestRequestIDMiddleware_UseExistingID * TestLoggingMiddleware * TestLoggingMiddleware_WithRequestID * TestRequestIDMiddleware_MultipleRequests - Add comments explaining why these tests cannot run in parallel - All tests now pass with race detector enabled (-race flag) This fixes data race warnings that were occurring when running tests with the race detector, specifically when multiple tests tried to set Gin's mode concurrently.- Add package comments to all packages (pkg/config, pkg/logger, internal/*, cmd/platform) - Fix context key warnings by using custom ContextKey type - Export ContextKey type to avoid unexported-return warnings - Update all context value operations to use ContextKey instead of string - Update RequestIDKey() and UserIDKey() to return ContextKey - Fix error checking issues (errcheck) - Properly handle os.Chdir errors in defer statements - Properly handle os.Setenv/os.Unsetenv errors in tests - Fix security warnings (gosec) - Change directory permissions from 0755 to 0750 in tests - Change file permissions from 0644 to 0600 in tests - Fix unused parameter warnings (revive) - Replace unused parameters with _ in: * RegisterLifecycleHooks lifecycle functions * Mock logger implementations * noOpLogger methods - Fix type assertion issues (staticcheck) - Remove unnecessary type assertions in tests - Use simpler compile-time checks - Fix exported type stuttering warning - Add nolint directive for ConfigProvider (standard interface pattern) - Update golangci-lint configuration - Add version: 2 field (required for newer versions) - Remove unsupported linters (typecheck, gosimple) - Move formatters (gofmt, goimports) to separate formatters section - Simplify linter list to only well-supported linters All linting issues resolved (0 issues reported by golangci-lint). All tests pass and code compiles successfully.