feature/microservice-architecture #5

Merged

master merged 15 commits from feature/microservice-architecture into main 2025-11-06 13:47:18 +01:00

Conversation 0 Commits 15 Files Changed 82 +5463 -1680

master commented 2025-11-06 09:25:49 +01:00

Owner

Copy Link

No description provided.

master added 4 commits 2025-11-06 09:25:50 +01:00

docs: Align documentation with true microservices architecture ... 38a251968c

Transform all documentation from modular monolith to true microservices
architecture where core services are independently deployable.

Key Changes:
- Core Kernel: Infrastructure only (no business logic)
- Core Services: Auth, Identity, Authz, Audit as separate microservices
  - Each service has own entry point (cmd/{service}/)
  - Each service has own gRPC server and database schema
  - Services register with Consul for service discovery
- API Gateway: Moved from Epic 8 to Epic 1 as core infrastructure
  - Single entry point for all external traffic
  - Handles routing, JWT validation, rate limiting, CORS
- Service Discovery: Consul as primary mechanism (ADR-0033)
- Database Pattern: Per-service connections with schema isolation

Documentation Updates:
- Updated all 9 architecture documents
- Updated 4 ADRs and created 2 new ADRs (API Gateway, Service Discovery)
- Rewrote Epic 1: Core Kernel & Infrastructure (infrastructure only)
- Rewrote Epic 2: Core Services (Auth, Identity, Authz, Audit as services)
- Updated Epic 3-8 stories for service architecture
- Updated plan.md, playbook.md, requirements.md, index.md
- Updated all epic READMEs and story files

New ADRs:
- ADR-0032: API Gateway Strategy
- ADR-0033: Service Discovery Implementation (Consul)

New Stories:
- Epic 1.7: Service Client Interfaces
- Epic 1.8: API Gateway Implementation

refactor: Align Epic 0 & Epic 1 with true microservices architecture ... 16731fc1d1

Refactor core kernel and infrastructure to support true microservices
architecture where services are independently deployable.

Phase 1: Core Kernel Cleanup
- Remove database provider from CoreModule (services create their own)
- Update ProvideHealthRegistry to not depend on database
- Add schema support to database client (NewClientWithSchema)
- Update main entry point to remove database dependency
- Core kernel now provides only: config, logger, error bus, health, metrics, tracer, service registry

Phase 2: Service Registry Implementation
- Create ServiceRegistry interface (pkg/registry/registry.go)
- Implement Consul registry (internal/registry/consul/consul.go)
- Add Consul dependency (github.com/hashicorp/consul/api)
- Add registry configuration to config/default.yaml
- Add ProvideServiceRegistry() to DI container

Phase 3: Service Client Interfaces
- Create service client interfaces:
  - pkg/services/auth.go - AuthServiceClient
  - pkg/services/identity.go - IdentityServiceClient
  - pkg/services/authz.go - AuthzServiceClient
  - pkg/services/audit.go - AuditServiceClient
- Create ServiceClientFactory (internal/client/factory.go)
- Create stub gRPC client implementations (internal/client/grpc/)
- Add ProvideServiceClientFactory() to DI container

Phase 4: gRPC Service Definitions
- Create proto files for all core services:
  - api/proto/auth.proto
  - api/proto/identity.proto
  - api/proto/authz.proto
  - api/proto/audit.proto
- Add generate-proto target to Makefile

Phase 5: API Gateway Implementation
- Create API Gateway service entry point (cmd/api-gateway/main.go)
- Create Gateway implementation (services/gateway/gateway.go)
- Add gateway configuration to config/default.yaml
- Gateway registers with Consul and routes requests to backend services

All code compiles successfully. Core services (Auth, Identity, Authz, Audit)
will be implemented in Epic 2 using these foundations.

chore: Clean up duplicate files and update .gitignore ... 9c21ece585

- Remove duplicate services/gateway/internal/gateway.go
- Add api-gateway binary to .gitignore

chore: Remove duplicate gateway.go file from internal directory 8ac85f9b1c

master added 1 commit 2025-11-06 09:45:30 +01:00

feat: upgrade to Go 1.25.3 and update build to include api-gateway ... fbc3fc37e4

- Create ADR-0034 documenting Go version upgrade to 1.25.3
- Mark ADR-0002 as superseded by ADR-0034
- Update CI workflow to use Go 1.25.3
- Update Makefile to build both platform and api-gateway binaries
- Update CI workflow to build and upload both binaries
- Update documentation (ADR README and mkdocs.yml) to include ADR-0034

master added 2 commits 2025-11-06 09:53:47 +01:00

test: add comprehensive tests for API Gateway implementation ... 260bc07114

- Add unit tests for gateway service (services/gateway/gateway_test.go)
  - Test gateway creation, route setup, service discovery, and error handling
  - Achieve 67.9% code coverage for gateway service
  - Test all HTTP methods are properly handled
  - Test route matching and 404 handling

- Add tests for API Gateway main entry point (cmd/api-gateway/main_test.go)
  - Test DI container setup and structure
  - Test service instance creation logic
  - Test lifecycle hooks registration

- Add testify dependency for assertions (go.mod)

All tests pass successfully. Proxy forwarding tests are noted for integration
test suite as they require real HTTP connections (per ADR-0028 testing strategy).

fix(ci): update golangci-lint to support Go 1.25.3 ... 557e6a009e

- Replace manual golangci-lint v2.1.6 installation (built with Go 1.24)
- Use official golangci/golangci-lint-action@v6 GitHub Action
- Set version to v2.6.0 which supports Go 1.25+
- Action automatically handles Go version compatibility

Fixes CI error: 'the Go language version (go1.24) used to build
golangci-lint is lower than the targeted Go version (1.25.3)'

master added 1 commit 2025-11-06 10:07:23 +01:00

fix: resolve test race conditions and update golangci-lint action ... c05038ccf2

- Fix race condition in gateway tests by using TestMain to set Gin mode once
  - Remove duplicate gin.SetMode(gin.TestMode) calls from individual tests
  - Add TestMain function to initialize test environment before all tests
  - Prevents race conditions when tests run in parallel with -race flag

- Update golangci-lint-action from v6 to v7
  - v6 doesn't support golangci-lint v2.x versions
  - v7 supports golangci-lint v2.x and automatically selects compatible version
  - Change version from v2.6.0 to latest for automatic compatibility

All tests now pass with race detector enabled.

master added 1 commit 2025-11-06 10:14:34 +01:00

fix(ci): update golangci-lint config for v2.6 compatibility ... b56b3c8c93

- Change version from number to string: version: "2"
- Remove deprecated exclude-use-default option
- Change exclude-rules to exclude (new format in v2.6)
- Remove deprecated output section (print-issued-lines, print-linter-name)
- Remove linters-settings (not allowed in v2.6 schema validation)

Fixes CI validation errors with golangci-lint v2.6.1:
- version type validation error
- exclude-use-default and exclude-rules not allowed
- output options not allowed
- linters-settings not allowed at root level

master added 1 commit 2025-11-06 10:17:57 +01:00

fix(ci): align golangci-lint config with v2.6 schema (remove 'issues.exclude') cd57fe7c14

master added 1 commit 2025-11-06 10:30:20 +01:00

fix(lint): resolve golangci-lint errors ... 767654f257

- Fix errcheck: explicitly ignore tx.Rollback() error in defer
  - When transaction commits successfully, Rollback() returns an error (expected)
  - Use defer func() with explicit error assignment to satisfy linter

- Remove unused connectToService function
  - Function is not currently used (proto files not yet generated)
  - Commented out with TODO for future implementation
  - Prevents unused function lint error

master added 1 commit 2025-11-06 10:33:24 +01:00

fix(lint): remove unused grpc imports from auth_client after commenting out connectToService a9b8df06f3

master added 1 commit 2025-11-06 10:35:27 +01:00

fix(fmt): format code a1586cb302

master added 1 commit 2025-11-06 10:57:14 +01:00

docs: ensure newline before lists across docs for MkDocs rendering b4b918cba8

master added 1 commit 2025-11-06 13:29:36 +01:00

fix(docs): diagrams f9170bb00b

master merged commit da7a4e3703 into main 2025-11-06 13:47:18 +01:00

master deleted branch feature/microservice-architecture 2025-11-06 13:47:18 +01:00

master referenced this issue from a commit 2025-11-06 13:47:20 +01:00

Merge pull request 'feature/microservice-architecture' (#5) from feature/microservice-architecture into main

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

master

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolz/goplt#5

No description provided.